[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112008: Fix cmake checks for Grantlee dependency
From:       "Laurent Montel" <montel () kde ! org>
Date:       2013-08-11 8:10:07
Message-ID: 20130811081007.32090.1167 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112008/#review37496
-----------------------------------------------------------



CMakeLists.txt
<http://git.reviewboard.kde.org/r/112008/#comment27720>

    we use the same code in kde-workspace:
    find_package(KDeclarative QUIET CONFIG)
    set_package_properties(KDeclarative PROPERTIES DESCRIPTION "KDE Declarative (QML) \
support from kdelibs"  URL "http://www.kde.org"
                           TYPE REQUIRED
                           PURPOSE "Required for building ksmserver"
                          )
    
    
    we use same in :
      find_package(NepomukCore QUIET CONFIG)
      set_package_properties(NepomukCore PROPERTIES DESCRIPTION "The Nepomuk Core \
libraries" URL "http://www.kde.org" TYPE REQUIRED PURPOSE "Nepomuk extends the search \
and tagging functionalities in KMail and Akonadi")  
    



messageviewer/grantleefilters/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112008/#comment27719>

    ? you make hard requires and you use it ?
    so your check is not good too.
    If you do it you must to make it in other place but if you need it it's that your \
check is not good.


- Laurent Montel


On Aug. 11, 2013, 12:34 a.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112008/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 12:34 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> If Grantlee is not found or is too old, cmake fails abruptly in \
> messageviewer/grantleefilters/CMakeLists.txt due to missing cmake definitions, and \
> does not inform the user that Grantlee is required or what version or Grantlee is \
> required. The patch encloses this cmake code in a conditional to allow cmake to run \
> to completion and display a list of missing REQUIRED packages. 
> Since Grantlee is now a hard dependency, the QUIET keyword is also removed from the \
> Grantlee find_package() call.,  
> 
> Diffs
> -----
> 
> CMakeLists.txt e6cd732 
> messageviewer/grantleefilters/CMakeLists.txt 276d7c7 
> 
> Diff: http://git.reviewboard.kde.org/r/112008/diff/
> 
> 
> Testing
> -------
> 
> cmake was run with Grantlee missing, at version 0.1.4 and version 0.3.0. The first \
> two cases list Grantlee in the missing REQUIRED packages at the end of cmake's run, \
> while in the last case cmake succeeds. 
> 
> Thanks,
> 
> David Jarvie
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]