[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 111742: Renabled signature url for fingerprint lookup via kleopatra
From:       "Lindsay Mathieson" <lindsay.mathieson () gmail ! com>
Date:       2013-08-06 12:57:59
Message-ID: 20130806125759.9068.80240 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111742/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 10:57 p.m.)


Review request for Akonadi and Lindsay Mathieson.


Changes
-------

Code style fix


Description
-------

Added a url to the signature html in the message display for looking up the signature \
fingerprint via the kleopatra keysearch dialog. This simplifies the verification and \
addition of public keys.  The url invokes kleopatra with the args "--parent-windowsid \
<kmail window id> --query <fingerprint>"

To use it, select a kmail message that is cryptographically signed and click on the \
"Show Details" link of the signature status in the message view. It will be expanded \
                to show the signature details:
- "Message was signed by <person name> (Key ID: <fingerprint>)"

Click on the fingerprint link to invoke kleopatra with the details. kleopatra will \
display the key detail if found in the local db, otherwise a keyserver search dialog \
prefilled with the key fingerprint.


Diffs (updated)
-----

  messageviewer/viewer/objecttreeparser.cpp 3d26ced 
  messageviewer/viewer/urlhandlermanager.cpp 3186ac1 

Diff: http://git.reviewboard.kde.org/r/111742/diff/


Testing
-------

Viewed msgs with known and unknown signatures, using the signature link to invoke a \
vs of kleopatra that supports "--query" (see review 111741). Signature details were \
correctly found in kleopatra.


Thanks,

Lindsay Mathieson

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]