[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 111873: Minimise kleopatra to system tray on startup
From:       "Andre Heinecke" <aheinecke () intevation ! de>
Date:       2013-08-05 9:06:26
Message-ID: 20130805090626.5946.46642 () vidsolbach ! de
[Download RAW message or body]



> On Aug. 4, 2013, 8:30 a.m., Kevin Krammer wrote:
> > I wonder if it wouldn't be better to change the autostart behavior.
> > KWalletManager does the "only show tray icon" thing it is confusing the heck out \
> > of users. The launch a program an apparently nothing happens. Some repeatedly try \
> > to launch it and then give up and ask on the mailinglist or forum. 
> 
> Lindsay Mathieson wrote:
> Its a bit of a conundrum, both behaviours (always hide/vs always show) can be a \
> problem. 
> How about remembering its state? i.e start hidden if it was hidden when shutdown.
> 
> Kevin Krammer wrote:
> I guess it mostly matters on what kind of automatic starting we are talking about.
> If we are talking about a program being started through the restoration of a safed \
> session, then I think it should of course be restored in the state it was in when \
> the session was safed (whether that is an explicit safe or a safe on shutdown \
> doesn't matter, that is the user's choice anyhow). If we are talking about \
> autostart, i.e. triggered by an autostart .desktop file, then I guess either \
> behavior would be fine (leaning toward hidden). 
> See http://techbase.kde.org/KDE_System_Administration/Startup#ksmserver:_Session_Management_and_Autostart
> 

I have to agree with Kevin on this. At least for Windows we would have to define this \
out because Kleopatra is not autostarted there and users expect it in the foreground \
when they launch it "willingly". I don't know how the session restore usually works \
for other Programs but starting Kleopatra minimized by default seems wrong to me.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111873/#review37048
-----------------------------------------------------------


On Aug. 4, 2013, 12:10 a.m., Lindsay Mathieson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111873/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2013, 12:10 a.m.)
> 
> 
> Review request for KDEPIM and Andre Heinecke.
> 
> 
> Description
> -------
> 
> Currently kleopatra always displays its main window on startup, which is annoying \
> on logon when it should be just displaying in the tray (note: kleopatra always \
> displays in the tray, there is no option to disable this). This patch:
> - keeps the main window hidden on startup
> - adds a command line option "--show" to display the main window on request
> - adds the "--show" option to kdepims Tools|Certificate Manager" menu action
> 
> Note 2: This is identical behaviour to kgpg.
> 
> 
> This addresses bug 309461.
> http://bugs.kde.org/show_bug.cgi?id=309461
> 
> 
> Diffs
> -----
> 
> kleopatra/kleopatraapplication.cpp 91c07cf 
> kmail/kmmainwidget.cpp ce24d3e 
> 
> Diff: http://git.reviewboard.kde.org/r/111873/diff/
> 
> 
> Testing
> -------
> 
> From Cmd line:
> - "kleopatra". System Tray Icon is displayed, no main window
> - "kleopatra --show". System Tray Icon and Main Window are displayed
> - KMail - "Tools|Certificate Manager". Kleopatra main window is displayed.
> - Reboot. Just the system tray icon is displayed
> - Logout/Login. Just the system tray icon is displayed
> - From kleopatra System Tray Context Menu:
> * Open Certificate Manager
> * Configure Kleopatra
> * About Kleopatra
> All windows were displayed as expected.
> 
> 
> Thanks,
> 
> Lindsay Mathieson
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]