[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 109247: Make Toolbar Buttons Show Message Status
From: Torsten Grote <grote () kolabsys ! com>
Date: 2013-07-04 13:40:01
Message-ID: 3630920.Qp4z0ruS1V () t7laptop1
[Download RAW message or body]
[Attachment #2 (multipart/signed)]
[Attachment #4 (multipart/mixed)]
Hi Michael,
On Wednesday 03 July 2013 20:41:38 Michael Bohlender wrote:
> I do not know the code base so I don't understand why I was personally
> added as a reviewer.
I added you to the list of reviewers, because you currently work with Kontact
Touch and are therefore the best person to answer the open question in this
review about how this change would affect Kontact Touch.
Apparently, not all the communication about it is documented in the
reviewboard. Please find it attached.
Do you know if checkable action state and unchanged action name works for
Kontact Touch?
Kind Regards,
Torsten
--
Torsten Grote, Kolab Evangelist
Kolab Systems AG, Zürich, Switzerland
e: grote@kolabsys.com
t: +41 43 501 66 91
w: http://kolabsys.com
pgp: 274D 4F97 Torsten Grote
["forwarded message" (message/rfc822)]
Return-Path: <kde-pim-bounces@kde.org>
Received: from kolab01.kolabsys.com ([unix socket]) by kolab01.kolabsys.com (Cyrus \
v2.4.17-Kolab-2.4.17-1.el6.kolab_3.0) with LMTPA; Fri, 08 Mar 2013 \
14:28:39 +0100
X-Sieve: CMU Sieve 2.4
Received: from ext-mx01.kolabsys.com (unknown [178.209.35.102]) by \
kolab01.kolabsys.com (Postfix) with ESMTP id 3BFA4C0AE1 for \
<shared+shared/lists/kde.org/pim@kolabsys.com>; Fri, 8 Mar 2013 \
14:28:36 +0100 (CET)
Received: from localhost (fw01.kolabsys.com [127.0.0.1]) by ext-mx01.kolabsys.com \
(Postfix) with ESMTP id A7A5C338135 for \
<shared+shared/lists/kde.org/pim@kolabsys.com>; Fri, 8 Mar 2013 \
14:28:36 +0100 (CET)
X-Virus-Scanned: amavisd-new at kolabsys.com
X-Spam-Score: -2.908
X-Spam-Status: No, score=-2.908 tagged_above=-10 required=6.31 \
tests=[RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.628, T_DKIM_INVALID=0.01, \
T_FRT_CONTACT=0.01]
Received: from ext-mx01.kolabsys.com ([127.0.0.1]) by localhost (ext-mx.kolabsys.com \
[127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D6i02icY-Z+r for \
<shared+shared/lists/kde.org/pim@kolabsys.com>; Fri, 8 Mar 2013 \
14:28:35 +0100 (CET)
Received: from postbox.kde.org (postbox.kde.org [46.4.96.248]) by \
ext-mx01.kolabsys.com (Postfix) with ESMTP id E023D338115 for \
<shared+shared/lists/kde.org/pim@kolabsys.com>; Fri, 8 Mar 2013 \
14:28:35 +0100 (CET)
Received: from postbox.kde.org (localhost [IPv6:::1]) by postbox.kde.org (Postfix) \
with ESMTP id 628BEB37DE2; Fri, 8 Mar 2013 13:28:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=kde.org; s=default; \
t=1362749315; bh=N2DYu6RCQsixqkz3oS1IIirSiuFzqngRHP4EEoGhRuk=; \
h=From:To:Date:Message-ID:In-Reply-To:References:MIME-Version:Cc: \
Subject:Reply-To:List-Id:List-Unsubscribe:List-Post:List-Help: \
List-Subscribe:Content-Type:Content-Transfer-Encoding:Sender; b=NQ \
YjpjzeCkAJCCRZD5NyqKYPh4XiEluG1Ydvr/LJNaVO67S13M19D3+6cyStwEj3cKvXZ \
My+BZnc3W0U/EFr5aexH2W+9iGMKftAblpUT9QCtbJnkaNK+85q0hE9KFJ+eWFLSx+3 \
x8awapsStLeGGVV3/eTudygEma/t0sH1kFM=
X-Original-To: kde-pim@kde.org
Delivered-To: kde-pim@localhost.kde.org
Received: from mail.kdab.com (mail.kdab.com [188.40.50.12]) by postbox.kde.org \
(Postfix) with ESMTP id B9098B37DC8; Fri, 8 Mar 2013 13:28:16 +0000 \
(UTC)
Received: from localhost (localhost [127.0.0.1]) by mail.kdab.com (Postfix) with \
ESMTP id 7E95A4EC402A; Fri, 8 Mar 2013 14:28:16 +0100 (CET)
X-Virus-Scanned: by amavisd-new at kdab.com
Received: from mail.kdab.com ([127.0.0.1]) by localhost (mail.kdab.com [127.0.0.1]) \
(amavisd-new, port 10024) with ESMTP id 5mHrFf2geawW; Fri, 8 Mar 2013 14:28:15 +0100 \
(CET)
Received: from localhost (localhost [127.0.0.1]) by mail.kdab.com (Postfix) with \
ESMTP id 3561C4EC4025; Fri, 8 Mar 2013 14:28:15 +0100 (CET)
From: Andras Mantia <amantia@kde.org>
To: Torsten Grote <grote@kolabsys.com>
Date: Fri, 08 Mar 2013 15:27:53 +0200
Message-ID: <1384653.AY2uC0sR9J@stein>
User-Agent: KMail/4.11 pre (Linux/3.4.28-2.20-desktop; KDE/4.10.60; x86_64; \
git-e73460f; 2013-03-05)
In-Reply-To: <20130308132422.2648.25991@vidsolbach.de>
References: <20130305155456.27318.23614@vidsolbach.de> \
<20130308132422.2648.25991@vidsolbach.de>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.71 on 46.4.96.248
Cc: KDEPIM-Libraries <kde-pim@kde.org>
Subject: Re: [Kde-pim] Review Request 109247: Make Toolbar Buttons Show Message \
Status
X-BeenThere: kde-pim@kde.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: KDE PIM <kde-pim@kde.org>
List-Id: KDE PIM <kde-pim.kde.org>
List-Unsubscribe: <https://mail.kde.org/mailman/options/kde-pim>, \
<mailto:kde-pim-request@kde.org?subject=unsubscribe>
List-Post: <mailto:kde-pim@kde.org>
List-Help: <mailto:kde-pim-request@kde.org?subject=help>
List-Subscribe: <https://mail.kde.org/mailman/listinfo/kde-pim>, \
<mailto:kde-pim-request@kde.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: kde-pim-bounces@kde.org
Sender: kde-pim-bounces@kde.org
On Friday, March 08, 2013 01:24:22 PM Torsten Grote wrote:
> > On March 5, 2013, 3:54 p.m., Laurent Montel wrote:
> > > Seems correct.
> > > Ship it in 4.10 I will merge after in master
> > > (if you can't I will apply it)
> >
> > Andras Mantia wrote:
> > I already told to him in person, but I will also say it here: note
> > that with the patch the action in the context menu looks a little
> > weird, it will say "[x] Remove Important Mark". I'm not against the
> > patch as indeed, this makes sense when the action is on the toolbar
> > and I have no real solution for the problem (aside of not changing
> > the action name, but just keeping the checkable state).
> Is anybody seeing a problem with the context menu behavior?
> I think that just not changing the action name would be the best solution.
> If you like, I can change the patch accordingly.
Thinking it more, it might be like it is now (changing texts) because of
Kontact Touch. But this has to be verified, I don't have it built now.
Andras
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
["signature.asc" (application/pgp-signature)]
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic