[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 110417: Small fixes for KMSystemTray
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-14 22:50:56
Message-ID: 20130514225056.21165.42579 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110417/#review32534
-----------------------------------------------------------


This review has been submitted with commit 4b5357ae6d5fa09e95a798cf8f4b21e9cb7b610b \
by Allen Winter to branch KDE/4.10.

- Commit Hook


On May 13, 2013, 2:15 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110417/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 2:15 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Small fixes for KMSystemTray:
> 
> * use the kmkernel macro consistently throughout
> * change buildPopupMenu to a bool method.
> * in buildPopupMenu, return first thing if no mainwidget; thereby eliminating a \
>                 possible useless leak of a KMenu pointer
> * in slotContextMenuAboutToShow, detect if building the popup has failed and quit \
> first thing if it did.  This might fix bug 319254 
> 
> Diffs
> -----
> 
> kmail/kmsystemtray.h 73048ba 
> kmail/kmsystemtray.cpp 6d027c0 
> 
> Diff: http://git.reviewboard.kde.org/r/110417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Allen Winter
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]