[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 110302: Save memory in VCardParser by sharing common strings
From: "Commit Hook" <null () kde ! org>
Date: 2013-05-05 14:04:00
Message-ID: 20130505140400.20020.94389 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110302/
-----------------------------------------------------------
(Updated May 5, 2013, 2:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDEPIM-Libraries.
Description
-------
Many strings common to the VCard format where not shared resulting
in an exessive memory consumption. Now these strings are interned
to leverage implicit sharing.
Note: To furthermore decrease the amount of QByteArray -> QString
conversions this code uses a (trivial) custom interning cache
instead of reusing Akonadi::Internal::SharedValuePool.
Diffs
-----
kabc/vcardparser/vcardparser.cpp c7b7a5a
Diff: http://git.reviewboard.kde.org/r/110302/diff/
Testing
-------
Massif shows that this patch reduces the memory consumption for
running testread on a file containing 10k randomly generated vcards
by ~6MB or by nearly 16% from a total of about 38MB.
Thanks,
Milian Wolff
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic