[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 109914: [IMAP] Use itemsRetrievedIncremental() when fetching missing bo
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-09 12:09:55
Message-ID: 20130409120955.9830.691 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109914/#review30777
-----------------------------------------------------------


This review has been submitted with commit 21d70d539c4b9a33939e75c28f2b2536ebe985d2 \
by Dan Vrátil to branch master.

- Commit Hook


On April 8, 2013, 4:54 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109914/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 4:54 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> After RetrieveItemsTask finishes retrieving new emails or missing bodies, it \
> fetches flags of emails 1...firstFetchedEmail. But in case of missing bodies fetch, \
> the firstFetchedEmail does not have to be the newest item in the folder, so flags \
> of (firstFetchedEmail + 1)...lastEmailInFolder are never retrieved and calling \
> itemsRetrievalDone() causes Akonadi to drop all the messages in this range, as \
> described in the referenced bug. 
> Using itemsRetrievedIncremental() when retrieving missing bodies fixes the issue, \
> and I think it also makes more sense in this context, because syncing flags should \
> be only done during regular sync. 
> 
> This addresses bug 316521.
> http://bugs.kde.org/show_bug.cgi?id=316521
> 
> 
> Diffs
> -----
> 
> resources/imap/retrieveitemstask.cpp 5129297 
> 
> Diff: http://git.reviewboard.kde.org/r/109914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]