[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 109825: Display KNotification and KStatusNotifier for Facebook notifica
From:       "Kevin Krammer" <krammer () kde ! org>
Date:       2013-04-08 18:47:41
Message-ID: 20130408184741.12990.74322 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109825/#review30715
-----------------------------------------------------------



resources/facebook/facebookresource_notifications.cpp
<http://git.reviewboard.kde.org/r/109825/#comment22861>

    I think the singular case should be "You have one new Facebook notification"



resources/facebook/facebookresource_notifications.cpp
<http://git.reviewboard.kde.org/r/109825/#comment22863>

    facebookresource.cpp has constants for that remoteId.
    maybe you can share them somehow, e.g. putting them into a separate header and \
including that in all sources or making a private method that just returns the \
constant.  String duplications can easily lead to typos or get out of sync



resources/facebook/facebookresource_notifications.cpp
<http://git.reviewboard.kde.org/r/109825/#comment22862>

    Akonadi jobs autodelete themselves.
    Since you need a new slot anyway, I recommend discarding the collectionReceived() \
connect and just connect the result signal. You can retrieve the fetched collections \
through CollectionFetchJob::collections()


- Kevin Krammer


On April 8, 2013, 4:55 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109825/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 4:55 p.m.)
> 
> 
> Review request for KDEPIM and Plasma.
> 
> 
> Description
> -------
> 
> This patch displays a KNotification whenever an unread notification exists on \
> Facebook. This KNotification groups at most 3 notifications into one popup and then \
> say "...and N more" if there is more. It also keeps track of which notifications \
> were already displayed and does not display them again unless they were updated on \
> the server. This is all stored in a separate config file.  
> Then it creates a KSNI for the notifications where it always show the newest three \
> notifications in the tooltip (regardless if it was displayed before or not) and \
> creates a menu with the notifications, which opens browser with the notification \
> link. 
> 
> Diffs
> -----
> 
> resources/facebook/CMakeLists.txt e8c6381 
> resources/facebook/facebookresource.h 4a16c0c 
> resources/facebook/facebookresource.cpp 67e8f3b 
> resources/facebook/facebookresource_notifications.cpp 7f6b8c4 
> resources/facebook/serializer/akonadi_serializer_socialnotification.cpp a261e14 
> resources/facebook/settingsbase.kcfg 9f8e4b5 
> resources/facebook/settingsdialog.cpp bfb7826 
> resources/facebook/settingsdialog.ui 68b6a24 
> 
> Diff: http://git.reviewboard.kde.org/r/109825/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> File Attachments
> ----------------
> 
> KSNI
> http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/facebook_notifications.png
>  
> 
> Thanks,
> 
> Martin Klapetek
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]