'Re: [Kde-pim] Review Request 109576: Fixing parsing inline messages with objectTreeParser'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 109576: Fixing parsing inline messages with objectTreeParser
From:       Sandro_Knauß <mail () sandroknauss ! de>
Date:       2013-03-21 0:21:41
Message-ID: 20130321002141.692.50121 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109576/
-----------------------------------------------------------

(Updated March 21, 2013, 12:21 a.m.)

Status
------

This change has been discarded.

Review request for KDEPIM.

Description
-------

Fixing parsing inline messages with objectTreeParser

If an inline message is parsed with objectTreeParser::parseObjectTree
a malformed html is generated, and plainText will have an additionally
newline:

  <body>
    <div style="position: relative; word-wrap: break-word">
      <a name="att"/>
      <div id="attachmentDiv">
        <table cellspacing="1" cellpadding="1" class="encr">
          <tr class="encrH">
            <td dir="ltr">Encrypted message</td>
          </tr>
          <tr class="encrB">
            <td>
              <div class="noquote">
                <div dir="ltr">some random text</div>
              </div>
            </td>
          </tr>
          <tr class="encrH">
            <td dir="ltr">End of encrypted message</td>
          </tr>
        </table>
      </div>
    </div>
  </div> <!-- his one is too much -->
  </body>

plainText: "some random text\n"

Diffs
-----

  messageviewer/objecttreeparser.cpp bb951d7486dad2941409bffd930797026785b706 
  messageviewer/tests/objecttreeparsertest.cpp fa9672b4d2249b509a84a3ff90829fd427a08e9c 

Diff: http://git.reviewboard.kde.org/r/109576/diff/

Testing
-------

Thanks,

Sandro Knauß

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread] 