[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 109247: Make Toolbar Buttons Show Message Status
From: Andras Mantia <amantia () kde ! org>
Date: 2013-03-08 13:27:53
Message-ID: 1384653.AY2uC0sR9J () stein
[Download RAW message or body]
On Friday, March 08, 2013 01:24:22 PM Torsten Grote wrote:
> > On March 5, 2013, 3:54 p.m., Laurent Montel wrote:
> > > Seems correct.
> > > Ship it in 4.10 I will merge after in master
> > > (if you can't I will apply it)
> >
> > Andras Mantia wrote:
> > I already told to him in person, but I will also say it here: note
> > that with the patch the action in the context menu looks a little
> > weird, it will say "[x] Remove Important Mark". I'm not against the
> > patch as indeed, this makes sense when the action is on the toolbar
> > and I have no real solution for the problem (aside of not changing
> > the action name, but just keeping the checkable state).
> Is anybody seeing a problem with the context menu behavior?
> I think that just not changing the action name would be the best solution.
> If you like, I can change the patch accordingly.
Thinking it more, it might be like it is now (changing texts) because of
Kontact Touch. But this has to be verified, I don't have it built now.
Andras
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic