'Re: [Kde-pim] Review Request 109264: Store collection paths instead of collection ids in filter conf'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 109264: Store collection paths instead of collection ids in filter conf
From:       "Andras Mantia" <amantia () kde ! org>
Date:       2013-03-03 17:35:51
Message-ID: 20130303173551.27663.17181 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109264/
-----------------------------------------------------------

(Updated March 3, 2013, 5:35 p.m.)

Review request for KDEPIM-Libraries and Volker Krause.

Changes
-------

Use a mutex, fix spaces.

Description
-------

Currently the filter configuration contains a collection id. This id is specific to a \
single akonadi instance, thus making impossible to synchronize the configuration file \
between computers and also invalidates all the filters in case of Akonadi database \
corruption and recreation. To fix this there was a need to extend the client \
                libraries. This patch:
- adds a new mode to the ETM so we can get the real name of a collection, not only \
                the display name
- adds a helper class to the CollectionPathResolver to have a better way of running \
it in blocking mode. CollectionPathResolver is private, but installed and I guess it \
is ok to use from kdepim itself.

Obviously I will commit the changes independently (ETM and CollectionPathResolver).

Diffs (updated)
-----

  akonadi/collectionpathresolver.cpp fd3551a 
  akonadi/collectionpathresolver_p.h 12a54ff 
  akonadi/entitytreemodel.h d55b73d 
  akonadi/entitytreemodel.cpp e2bd1d8 

Diff: http://git.reviewboard.kde.org/r/109264/diff/

Testing
-------

Thanks,

Andras Mantia

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread] 