From kde-pim  Sun Mar 03 11:05:34 2013
From: "Andras Mantia" <amantia () kde ! org>
Date: Sun, 03 Mar 2013 11:05:34 +0000
To: kde-pim
Subject: Re: [Kde-pim] Review Request 109198: when removing maildir folder X, also remove .X.directory with s
Message-Id: <20130303110534.7099.77153 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=136230875610846


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109198/#review28432
-----------------------------------------------------------

Ship it!


Looks good, you can also change the QString::fromLatin1( ".%1.directory" ).arg( folderName ) codes to subDirNameForFolderName( const QString &folderName ). Please commit to 4.10 branch and merge the branch to master after.

- Andras Mantia


On Feb. 28, 2013, 12:12 a.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109198/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 12:12 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> until now, the contents of the subfolders in .X.directory have already been deleted but the directory structure remained
> 
> there are more places in maildir.cpp where subDirNameForFolderName could be used instead of QString(".%1.directory").arg(folderName), 
> but maybe I can simply do that without review?
> 
> 
> Diffs
> -----
> 
>   resources/maildir/libmaildir/maildir.cpp 6355b4ab44ecada94a379b82c52e1315a2894eb7 
> 
> Diff: http://git.reviewboard.kde.org/r/109198/diff/
> 
> 
> Testing
> -------
> 
> removing maildir folders with subfolders (using kmail), readding them
> 
> 
> Thanks,
> 
> Wolfgang Rohdewald
> 
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/