[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: [Kde-pim] Review Request 109186: work around a file descriptor leak when using QFileSystemWatcher
From: "Wolfgang Rohdewald" <wolfgang () rohdewald ! de>
Date: 2013-02-27 9:32:14
Message-ID: 20130227093214.28778.64484 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109186/
-----------------------------------------------------------
Review request for KDEPIM.
Description
-------
this cleans up some code and avoids warnings from QFileSystemWatcher when many mails \
are moved between folders. QFileSystemWatcher leaks four file descriptors for every \
moved mail because removeDir does not close the fd (as can be seen in /proc/X/fd \
where X is the process id of akonadi_agent_launcher akonadi_maildir_resource). On my \
system (kubuntu 12.10) warnings start when 1024 file descriptors are open.
I did not yet investigate which notifying method QFileSystemWatcher actually uses.
This has 3 commits:
1. factor out common code
2. add a missing restore command in an error path
3. do not use removeDir/addDir but stopDirScan/restartDirScan
Diffs
-----
resources/maildir/maildirresource.h f792b23f49cd493f128602649384d2a790ec3b47
resources/maildir/maildirresource.cpp 6485f99d8f81cc46913cc473978ace818cbd114d
Diff: http://git.reviewboard.kde.org/r/109186/diff/
Testing
-------
moving mails between folders. Needed time is about the same as before (like 50 \
seconds for 900 mails)
Thanks,
Wolfgang Rohdewald
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic