[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request: Close AttachmentMissingWarning after attach file
From:       "Torsten Grote" <grote () kolabsys ! com>
Date:       2012-12-26 10:14:45
Message-ID: 20121226101445.22782.44067 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107916/
-----------------------------------------------------------

Review request for KDEPIM and Laurent Montel.


Description
-------

Currently, the AttachmentMissingWarning at the bottom of the compose window is only \
closed when attaching a file with its own button, but not when attaching files by \
other means. I made showAddAttachmentDialog() emit a fileAttached() signal which in \
turn deactivates the warning. Maybe there is a better place to emit this signal e.g. \
when a file has successfully been attached.


Diffs
-----

  kmail/kmcomposewin.h e6dadb1fa44ba0767e14b3f69a4279da2114b36f 
  kmail/kmcomposewin.cpp 1306c2b9ada644824e5a505d7c199d69506f9d74 
  messagecomposer/attachmentcontrollerbase.h 3c15c66700c7227e1bebd546ec1d3e11ec01d973 \
  messagecomposer/attachmentcontrollerbase.cpp \
68253e74a24074a012423940a25bc73b4a3c8941 

Diff: http://git.reviewboard.kde.org/r/107916/diff/


Testing
-------


Thanks,

Torsten Grote

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]