[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: ktimetracker tray icon doesn't connect to right signals
From:       "Allen Winter" <winter () kde ! org>
Date:       2012-12-24 16:14:16
Message-ID: 20121224161416.11706.3837 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107482/#review23962
-----------------------------------------------------------

Ship it!


You can ship it. remove the unnecessary include as Laurent pointed out.
Do you have a commit account or do you need someone to commit for you?

- Allen Winter


On Nov. 26, 2012, 9:01 p.m., Chuso Perez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107482/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2012, 9:01 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> MainWindow tries to connect TrayIcon slots to some signals sent by \
> TimetrackerWidget. But these signals are not being emitted by TimetrackerWidget, \
> they are being emitted by TaskView. This code patches TimetrackerWidget to receive \
> those TaskView signals and propagate them so MainWindow can receive them to connect \
> them to TrayIcon. 
> 
> This addresses bug 289009.
> http://bugs.kde.org/show_bug.cgi?id=289009
> 
> 
> Diffs
> -----
> 
> ktimetracker/timetrackerwidget.cpp f2d1d7a 
> 
> Diff: http://git.reviewboard.kde.org/r/107482/diff/
> 
> 
> Testing
> -------
> 
> Those methods from TrayIcon that are expected to be run when the signal is sent \
> (change tray icon and update tool tip) are finally run (they are not being run \
> until now, see bug). 
> 
> Thanks,
> 
> Chuso Perez
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]