[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Only emit MailFilterAgent progress signal on dbus when progress has be
From:       "Andreas Hartmetz" <ahartmetz () gmail ! com>
Date:       2012-12-09 21:02:58
Message-ID: 20121209210258.22995.42213 () vidsolbach ! de
[Download RAW message or body]



> On Dec. 9, 2012, 7:46 p.m., Andras Mantia wrote:
> > Thanks for the patch, but I already fixed it. :)
> 
> Andras Mantia wrote:
> Hm, I just saw the patch is against the fixed version. So you still see it? The \
> timer now should be stopped in case the percent is set to zero.

Looks like I had a version without your fix running, and my latest recompile included \
both patches. Oops.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107651/#review23218
-----------------------------------------------------------


On Dec. 9, 2012, 7:43 p.m., Andreas Hartmetz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107651/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 7:43 p.m.)
> 
> 
> Review request for Akonadi, Tobias Koenig, Volker Krause, and Andras Mantia.
> 
> 
> Description
> -------
> 
> While watching the output of dbus-monitor, I saw a MailFilterAgent progress message \
> about every second, and it was always zero percent. This fix is a band-aid and only \
> hides what I consider the real bug. Maybe it makes sense on its own. 
> 
> Diffs
> -----
> 
> mailfilteragent/mailfilteragent.cpp f69945c 
> 
> Diff: http://git.reviewboard.kde.org/r/107651/diff/
> 
> 
> Testing
> -------
> 
> Before I could see a progress message every second in dbus-monitor, with the patch \
> they were gone. 
> 
> Thanks,
> 
> Andreas Hartmetz
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]