[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: iCal format fixes for CREATED and DTSTAMP
From: "Allen Winter" <winter () kde ! org>
Date: 2012-12-06 21:18:11
Message-ID: 20121206211811.18924.18953 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107480/#review23097
-----------------------------------------------------------
seems ok to me. I'd like David Jarvie's ok though
- Allen Winter
On Dec. 6, 2012, 7:26 p.m., Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107480/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2012, 7:26 p.m.)
>
>
> Review request for KDEPIM, KDEPIM-Libraries and David Jarvie.
>
>
> Description
> -------
>
> This patch fixes the uses of CREATED and DTSTAMP in respect to RFC5545 (iCal) and RFC5546 \
> (iTip).
> CREATED was used as serialization timestamp, which is IMO wrong as it should preserve the \
> creation date of the conceptual ical object. The dtstamp was written as creation-date but \
> never read back, but it should be the last-modification-date without METHOD (iTip), and the \
> time of serialization with a METHOD.
> This patch fixes the following problems:
> * dtstamp and created exchanged when writing any ical object
> * created date is not preserved
> * last-modification-date is not preserved
> * vFreebusy iTip messages contains a created date (but must not)
>
> As a sideeffect this patch also fixed the RecurNext* and RecurPrev* unittests.
>
> This patch should be safe to apply to existing systems.
>
>
> This addresses bugs 310448 and 310469.
> http://bugs.kde.org/show_bug.cgi?id=310448
> http://bugs.kde.org/show_bug.cgi?id=310469
>
>
> Diffs
> -----
>
> kcalcore/compat.h c74aa9d8037750e661bf7822b60ef01ab65b9a33
> kcalcore/compat.cpp 9447fff30dfc9242bb891b4ad54902b37aba58ab
> kcalcore/icalformat_p.cpp 418a92a6e1f033d1110add754c4966436585dea2
> kcalcore/tests/CMakeLists.txt 10f449dc3c83293b923c02dc6e429df5e60d3996
> kcalcore/tests/testcreateddatecompat.h PRE-CREATION
> kcalcore/tests/testcreateddatecompat.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/107480/diff/
>
>
> Testing
> -------
>
> checked existing unit tests (all pass). Running the patch on my productive system now.
>
>
> Thanks,
>
> Christian Mollekopf
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic