[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Fix saving and loading of suspended reminders in KOrganizer
From:       "Commit Hook" <null () kde ! org>
Date:       2012-12-05 19:58:39
Message-ID: 20121205195839.27738.75970 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107546/#review23046
-----------------------------------------------------------


This review has been submitted with commit d1d99767eed455ee6f152ca9b7461f7a9a9acaa0 \
by Frank Roscher to branch master.

- Commit Hook


On Dec. 2, 2012, 10:55 a.m., Frank Roscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107546/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2012, 10:55 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Shortly after fixing reminders that trigger while korgac is not running, I had to \
> find out that suspended reminders work differently and are buggy, too. This patch \
> should fix the following two (related) issues: 1. Suspended reminders are not \
> loaded correctly at korgac startup because collections haven't been populated. 2. \
> Suspended reminders are forgotten if they don't get triggered between two shutdowns \
> of korgac. This happens because the code only saves them to a config file when they \
> are explicitly (re-)suspended, but removes them from the file on startup. 
> The patch fixes this by changing the following:
> - It introduces a method deferredInit that gets called when the collections have \
> been populated. The code for loading suspended reminders from the config file is \
> moved here from the constructor. The first check for reminders is triggered from \
>                 here as well.
> - The saved suspended reminders are not deleted from the config file anymore on \
> startup. Instead, they are deleted from there only when they are dismissed by the \
> user after having triggered. In order to adjust to this behaviour, slotSave of the \
> alarm dialog does not append to the reminder list in the config file anymore, but \
> replaces it instead (because the dialog is supposed to know about all suspended \
>                 reminders anyway). 
> - A new method collectionsAvailable is introduced because we need to check the \
> collection population status in two different places now; this is not new code. Two \
> kDebug statements were removed here due to reduced usefulness in this more general \
> context. 
> The patch is pretty straightforward and should be a clear improvement, but it is \
> possible I'm missing some code that ties into this and needs to be adjusted as \
> well. 
> 
> This addresses bug 280321.
> http://bugs.kde.org/show_bug.cgi?id=280321
> 
> 
> Diffs
> -----
> 
> korganizer/korgac/alarmdialog.cpp d3b41aa 
> korganizer/korgac/koalarmclient.h 9ec5316 
> korganizer/korgac/koalarmclient.cpp 81480bd 
> 
> Diff: http://git.reviewboard.kde.org/r/107546/diff/
> 
> 
> Testing
> -------
> 
> - Suspending reminders across shutdown of korgac and akonadi
> - Suspended reminders that trigger again only after _two_ shutdowns of korgac and \
>                 akonadi
> - Resuspending such reminders
> - Dismissal of reminders in all three scenarios described above.
> - Checked that config file does not get filled up with dead entries
> 
> 
> Thanks,
> 
> Frank Roscher
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]