[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Disable contact searching in message viewer
From:       "Andras Mantia" <amantia () kde ! org>
Date:       2012-10-24 7:15:58
Message-ID: 20121024071558.16885.13203 () vidsolbach ! de
[Download RAW message or body]



> On Oct. 23, 2012, 9:25 p.m., Laurent Montel wrote:
> > Sorry I will say "not commit it"
> > Perhaps there is a problem with ContactSearchJob (I don't have this problem), but \
> > it's not a solution to disable all the time nepomuk code. With this "#if 0" we \
> > will keep it disable, nobody will look at this bug and it will never work. I know \
> > that each time that we are a problem with nepomuk the solution is disable \
> > nepomuk. So why uses nepomuk in kmail...
> > 
> > in kdepim 4.9 we disable nepomuk search in AddresseeLine
> > 
> > {
> > KConfig config( QLatin1String( "kpimcompletionorder" ) );
> > const KConfigGroup group( &config, QLatin1String( "General" ) );
> > useNepomukCompletion = group.readEntry( "UseNepomuk", false );
> > }
> > 
> > 
> > nobody looked at how to fix it, I know that it will disable in 4.10 because \
> > nobody have time/want to fix it 
> > So don't add this workaround (it will add a dead code for sure).
> > 
> > For me we must fix nepomuk.
> > 
> > Regards.
> 
> Andras Mantia wrote:
> 
> I understand the reasoning, and I was expecting it. That's why I posted for a \
> review. :) 
> it is not that I don't want to fix Nepomuk, and we are aware of the \
> ContactSearchJob problems. Vishesh Handa also knows about it, and I'm sure we would \
> like to get that fixed. It is a strange problem though. When I posted the review, I \
> had big issues with it. After that I tried to debug and restarted nepomuk and the \
> problem is gone. Go figure. 
> Anyway, what about putting it in 4.9 only for now? 
> 
> Also what about the other part, that just doesn't call ContactSearchJob when it \
> doesn't make sense (for the context menu)? 
> Laurent Montel wrote:
> If there is a big problem in 4.9 ok we can put add the #if 0 in code (be carefull \
> when we merge it :)) But for messageviewer/headerstyle.cpp as Thomas I don't \
> understand it's right it's async so for me even if it's will take time it will not \
> make bad experience for kmail. Not necessary to add it. 
> "just doesn't call ContactSearchJob when it doesn't make sense" : I never see that \
> it called it all the time. Yes we must call it when necessary. ok for this part :) 
> Regards.

I will record a video when the messageviewer part happens again :) 
And I will do the optimization. ContactSearchJob was called previously always when \
you right clicked in some place in the message area, now it is only when you click on \
a mailto link.


- Andras


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107003/#review20765
-----------------------------------------------------------


On Oct. 23, 2012, 7:42 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107003/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 7:42 a.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> One of the slowest things nowadays in Kontact/KMail is searching for contacts using \
> Nepomuk via ContactSearchJob. Until this is fixed, I propose the following patch, \
> that disables lookup for contact photos (to be displayed in Fancy Headers) and \
> searching for contacts when right clicking in a mail. The second thing is somewhat \
> optimized, to search only if you clicked on a mailto link, and not in other cases, \
>                 but as that would be still slow, i added the #if 0 also around \
>                 that.
> Note: same code is in KMReaderMainWin, not fixed yet, just commented with TODO as \
> the real fix is merging the code. 
> This is not a real fix, is more like making KMail repsonsive *now*.
> 
> 
> Diffs
> -----
> 
> kmail/kmmainwidget.h bc9a76c 
> kmail/kmmainwidget.cpp d7d1660 
> kmail/kmreadermainwin.cpp 54ff7c5 
> messageviewer/headerstyle.cpp 26c0182 
> 
> Diff: http://git.reviewboard.kde.org/r/107003/diff/
> 
> 
> Testing
> -------
> 
> Test results: no more Retrieving Folder Contents message shown for 10+ seconds and \
> no 10+ second delay when right clicking in a mail. 
> 
> Thanks,
> 
> Andras Mantia
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]