[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Optimize ChangeRecorder to only update 8 bytes on disk when dequeuing.
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2012-10-22 14:00:28
Message-ID: 20121022140028.5154.89396 () vidsolbach ! de
[Download RAW message or body]



> On Oct. 21, 2012, 9:57 a.m., Volker Krause wrote:
> > Looks good to me, but I think we lost commit f142cc25 when the implementation of \
> > changerecorder_p.h was moved into its own file.
> 
> David Faure wrote:
> Wow git played a really nasty trick on me here. I still don't understand how this \
> could get lost. If you look at 343ab18, the "-" lines don't have that code. And git \
> log changerecorder_p.h doesn't show f142cc25, even though a more general "git log" \
> does. I can't make sense of this. 
> Anyway, I'll re-apply f142cc25 again on top, then.
> 
> One last question: 4.9 or master?
> On one hand it's a major performance fix, on the other hand I guess we don't want \
> to change a file format in 4.9.x, right?

Didn't make any sense to me either from looking at the history, I was doubting my own \
memories already, I was sure I had committed that fix ;-)

I'd be ok with putting this in 4.9 as well, the file format isn't used by anything \
else anyway.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106950/#review20613
-----------------------------------------------------------


On Oct. 19, 2012, 1:33 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106950/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2012, 1:33 p.m.)
> 
> 
> Review request for Akonadi, Volker Krause and Andras Mantia.
> 
> 
> Description
> -------
> 
> Optimize ChangeRecorder to only update 8 bytes on disk when dequeuing.
> 
> Rather than saving the whole file (of pending notifications) every
> time, just because the first item was dequeued. This reduces disk I/O
> considerably, and speeds up processing (especially in the nepomuk
> feeder). In the IMAP resource (when marking 2000 emails as read) I
> couldn't time a difference since it's mostly network-based anyway.
> But at least the disk is usable by other processes meanwhile ;)
> 
> 
> This addresses bug 300572.
> http://bugs.kde.org/show_bug.cgi?id=300572
> 
> 
> Diffs
> -----
> 
> akonadi/changerecorder.cpp c3d3640679a9a679449fa6f0ce1a34a9d79cf351 
> akonadi/changerecorder_p.h 1100579aaa6beb53725bb5fc96e2e5c356cbab54 
> akonadi/changerecorder_p.cpp 6582ba4e8391bf77686e4feabf06b4bdf6c1bfc3 
> 
> Diff: http://git.reviewboard.kde.org/r/106950/diff/
> 
> 
> Testing
> -------
> 
> changerecorder and monitornotification unit tests [is there any other that might \
> apply?] Applying the patch and restarting akonadi (existing files get converted to \
> new format). Running with the patch for a few days.
> Marking 2000 emails as read.
> Watching nepomukfeeder process all pending notifications.
> 
> 
> Thanks,
> 
> David Faure
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]