[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request: Optimize ChangeRecorder to only update 8 bytes on disk when dequeuing.
From:       "David Faure" <faure () kde ! org>
Date:       2012-10-19 13:33:29
Message-ID: 20121019133329.25966.77027 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106950/
-----------------------------------------------------------

Review request for Akonadi, Volker Krause and Andras Mantia.


Description
-------

Optimize ChangeRecorder to only update 8 bytes on disk when dequeuing.

Rather than saving the whole file (of pending notifications) every
time, just because the first item was dequeued. This reduces disk I/O
considerably, and speeds up processing (especially in the nepomuk
feeder). In the IMAP resource (when marking 2000 emails as read) I
couldn't time a difference since it's mostly network-based anyway.
But at least the disk is usable by other processes meanwhile ;)


This addresses bug 300572.
    http://bugs.kde.org/show_bug.cgi?id=300572


Diffs
-----

  akonadi/changerecorder.cpp c3d3640679a9a679449fa6f0ce1a34a9d79cf351 
  akonadi/changerecorder_p.h 1100579aaa6beb53725bb5fc96e2e5c356cbab54 
  akonadi/changerecorder_p.cpp 6582ba4e8391bf77686e4feabf06b4bdf6c1bfc3 

Diff: http://git.reviewboard.kde.org/r/106950/diff/


Testing
-------

changerecorder and monitornotification unit tests [is there any other that might apply?]
Applying the patch and restarting akonadi (existing files get converted to new format).
Running with the patch for a few days.
Marking 2000 emails as read.
Watching nepomukfeeder process all pending notifications.


Thanks,

David Faure

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]