[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request: Fix missing external parts with akonadi fsck
From: "Andras Mantia" <amantia () kde ! org>
Date: 2012-10-18 19:22:14
Message-ID: 20121018192214.12000.30068 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106872/#review20561
-----------------------------------------------------------
server/src/storagejanitor.cpp
<http://git.reviewboard.kde.org/r/106872/#comment16234>
Actually I just realized something, that might explain the QFSFileEngine::open: No file \
name specified errors from th akonadi server. When an external part is removed, it is not \
enough to set the data to null and datasize to 0, but the part must be marked as non-external \
with part.setExternal(false). The same problem appears in the cachecleaner, I'm about to test \
that: it calls PartHelper::truncate that does exactly what you did above, and also misses the \
part.setExternal(false).
That causes an empty file name to be returned for the payload data in fetchelper.
- Andras Mantia
On Oct. 15, 2012, 9:35 a.m., Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106872/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2012, 9:35 a.m.)
>
>
> Review request for Akonadi and Volker Krause.
>
>
> Description
> -------
>
> Fix missing external parts with akonadi fsck, by clearing the stored parts from the db. The \
> reason for having non-existing external parts is yet unknown.
>
> Diffs
> -----
>
> server/src/storagejanitor.cpp 4057a04487a34af113dbf40285965c8e896f566b
>
> Diff: http://git.reviewboard.kde.org/r/106872/diff/
>
>
> Testing
> -------
>
> Works for me.
>
>
> Thanks,
>
> Christian Mollekopf
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic