[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Prevent KOrganizer from ignoring reminders that trigger during downtim
From:       "Allen Winter" <winter () kde ! org>
Date:       2012-10-17 18:37:38
Message-ID: 20121017183738.12461.63602 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106824/#review20518
-----------------------------------------------------------


The code looks fine to me.  And makes sense as well.

But I would appreciate a review from David, Sergio or anyone else with a good \
understanding of Akonadi.


- Allen Winter


On Oct. 13, 2012, 3:04 p.m., Frank Sebastian Roscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106824/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 3:04 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Since the switch to Akonadi, KOrganizer has had a pretty serious bug: If the \
> collection and its items haven't already been loaded at the time of startup, the \
> first check for reminders is performed against an empty collection. When the \
> collection does show up, korgac thinks it has already checked for a backlog of \
> reminders and thus only displays reminders that were supposed to trigger during the \
> last minute or so. The result is that all reminders that are supposed to trigger \
> while korgac is not running are silently ignored. This is especially harsh for \
> birthday reminders, which usually get triggered at midnight. 
> This small patch tries to fix that using the new \
> collectionTreeFetched/isCollectionTreeFetched functionality in EntityTreeModel, \
> introduced by David Jarvie. 
> 
> This addresses bug 282535.
> http://bugs.kde.org/show_bug.cgi?id=282535
> 
> 
> Diffs
> -----
> 
> korganizer/korgac/koalarmclient.h adc8cef 
> korganizer/korgac/koalarmclient.cpp 34e9a42 
> 
> Diff: http://git.reviewboard.kde.org/r/106824/diff/
> 
> 
> Testing
> -------
> 
> I tested the triggering of reminders at startup in Xephyr sessions using a new user \
> account. Reminders in two separate collections instead of only one were tested. All \
>                 collections were local, though.
> Disclaimer: I have a very limited knowledge about the Akonadi internals and might \
> be fundamentally misunderstanding something about all this. Still, in my tests it \
> has worked flawlessly. 
> 
> Thanks,
> 
> Frank Sebastian Roscher
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]