[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request: Fix filter pipeline causing message duplication
From:       "Andras Mantia" <amantia () kde ! org>
Date:       2012-10-15 8:30:33
Message-ID: 20121015083033.16043.59573 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106869/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

For whoever has any comments before I commit. ;)
 
   Change the filtering pipeline. So far if there was a move and a modifier filter,
    the order was modify followed by move. Now it is move followed by modify.
    The original order in the filters doesn't matter, it is always reordered.
    The problems with the old approach was:
    - if there was a move and a payload modification job, the item was firt modified,
    the payload uploaded back to the original place and then moved. This caused an
    extra store in the backend, that e.g on IMAP causes quite heavy traffic.
    - due to the above behavior, it could happen that the payload change updates
    the remoteId, so the move afterwards moves the *original* item, while the
    modified remains in the original place. This results in mail duplication.
    The behavior was visible with spam filtering on IMAP.
    
    The patch also cleans up the filter processing a little, reducing the number of
    arguments passed to  process() and introduces simple error handling instead
    of the existing complex, but incomplete one.


Diffs
-----


Diff: http://git.reviewboard.kde.org/r/106869/diff/


Testing
-------


Thanks,

Andras Mantia

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]