[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Make E-Mail successfully sent / E-Mail sending failed messages prettie
From:       "Laurent Montel" <montel () kde ! org>
Date:       2012-10-07 13:07:02
Message-ID: 20121007130702.17209.18816 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106725/#review20033
-----------------------------------------------------------

Ship it!


Ok ship it
Thanks

- Laurent Montel


On Oct. 4, 2012, 2:33 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106725/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 2:33 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> This fixes the E-Mail Successfully Sent (and failed) messages using a hardcoded \
> size pixmap by moving the icon logic to the notifyrc. Also adds a title string that \
> sumarizes the messages. I used "mail-mark-junk" for mail sending failed because I \
> didn't want to use a generic dialog-error and we don't have an apporpriate error \
> icon for mails. I think it fits. 
> 
> Diffs
> -----
> 
> agents/maildispatcher/akonadi_maildispatcher_agent.notifyrc b3846c7 
> agents/maildispatcher/maildispatcheragent.cpp 04543ab 
> 
> Diff: http://git.reviewboard.kde.org/r/106725/diff/
> 
> 
> Testing
> -------
> 
> Tested it on 4.9 (on my project neon akonadi doesnt work) and sent a mail. New \
> pretty messages appeared (see screenshot). 
> 
> Screenshots
> -----------
> 
> Prettier notification
> http://git.reviewboard.kde.org/r/106725/s/754/
> Prettier error notification
> http://git.reviewboard.kde.org/r/106725/s/755/
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]