--===============4894971802916377350==
Content-Type: multipart/signed;
  boundary="nextPart21150249.78fysm7vHC";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart21150249.78fysm7vHC
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

On Monday, 2012-02-27, Jonathan Marten wrote:
> Kevin Krammer <kevin.krammer@gmx.at> writes:
> > On Monday, 2012-02-27, Jonathan Marten wrote:
> >> The only fix that I can think of so far is to add a property to the
> >> EntityTreeView to indicate whether the view is showing items or
> >> collections, to be set by the calling application.  It would only be
> >> used in the case of a click not over anything, and the default
> >=20
> > What about derving from EntityTreeView in KAddressBook and overwriting
> > the event handler method, delegating to base class implementation when
> > event position is on a valid item?
>=20
> That could be done, but getting the correct menu over empty space
> would mean duplicating nearly the whole of
> EntityTreeView::contextMenuEvent() in the application.  No point in
> doing this when the library is available, and it leaks the internal
> library implementation details.

Right.
The only option for fixing this in 4.8 (and 4.7) though.

> > I am not sure clicking in empty space will always result in either
> > collection or item context menu, an application could want different
> > behavior.
>=20
> But that's effectively the non-choice there is at present - empty
> space always gives the collection context menu.
>=20
> The property can be changed at any time - or, if dynamic per-click
> behaviour is required, then the application could reimplement the
> event handler as you suggest above.

Just in case somebody is interested but did not read the respective exchang=
e=20
on reviewboard (or its email notifications):

the final version we came up with allows to set a menu name (as in KXMLGUI=
=20
container name) which will be used to retrieve the context menu in case the=
=20
context menu is requested for a context that is not a tree entry.

Defaulting to the name of the collection context menu for compatibility.

This allows to select either item or collection context menu, a menu provid=
ed=20
by the application or even no context menu at all for those cases.

Cheers,
Kevin
=2D-=20
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

--nextPart21150249.78fysm7vHC
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQBPUPDunKMhG6pzZJIRAn0+AJ97IYQle/DNIbEx1nQl5YHC9qOJ/wCeK5qL
ebmVlZOWDpfi4/sUe/yFZTM=
=+dhc
-----END PGP SIGNATURE-----

--nextPart21150249.78fysm7vHC--

--===============4894971802916377350==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============4894971802916377350==--