[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: making kmail network-aware
From:       "Commit Hook" <null () kde ! org>
Date:       2012-03-02 16:00:49
Message-ID: 20120302160049.16241.37705 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/#review11085
-----------------------------------------------------------


This review has been submitted with commit 6a730cd010e58c8032ace0794345a066d851c195 \
by Matin Bednar to branch master.

- Commit Hook


On March 1, 2012, 9:44 p.m., Martin Bednar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102431/
> -----------------------------------------------------------
> 
> (Updated March 1, 2012, 9:44 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Changes Solid calls to not render KMail useless when Solid can't detect network \
> connection (same as Andreas did in isOffline). Asks the user to go online only \
> based on the internal Kmail networkState status, ignoring the status of the \
> network. Modifies behaviour of askToGoOnline() function to return false when there \
> is no network detected, thus making checkMailOnStartup() and checkMail() functions \
> network-aware. 
> 
> Diffs
> -----
> 
> kmail/kmkernel.h 35eaf28 
> kmail/kmkernel.cpp 86244a6 
> kmail/kmmainwidget.h f9c59a2 
> kmail/kmmainwidget.cpp 06bdb0e 
> 
> Diff: http://git.reviewboard.kde.org/r/102431/diff/
> 
> 
> Testing
> -------
> 
> compiles,runs, works fine with solid not detecting network, haven't bumped into any \
> issue with Solid working. 
> 
> Thanks,
> 
> Martin Bednar
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]