[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Emit changeProcessed() when an invalid folder is asked to be removed
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2012-02-29 10:04:23
Message-ID: 20120229100423.20459.13468 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104117/#review11013
-----------------------------------------------------------


Looks good overall. But of course you know what I'm going to ask: Unit tests? :-)

- Kevin Ottens


On Feb. 29, 2012, 9:29 a.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104117/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 9:29 a.m.)
> 
> 
> Review request for KDEPIM and Kevin Ottens.
> 
> 
> Description
> -------
> 
> In case the imap resource gets a request to remove a folder that doesn't exist, the \
> resource will not signal that the operation was processed. This is very important \
> if the request comes from the change recorder, as if it doesn't get the \
> changeProcessed() signal, it will not process the next change. This can result in \
> the resource being stopped, not syncing anymore. The actual cause (why the change \
> recorder had an entry that was not correct - a collection with remoteid "foo" \
> instead of "/fpo") is not yet known, but neverthless the resource should deal with \
> such case as well. 
> Please review asap, I'd like to put into 4.8 as well (with a different string, the \
> same used in the other error cases). 
> 
> Diffs
> -----
> 
> resources/imap/removecollectionrecursivetask.cpp 9e78cff 
> 
> Diff: http://git.reviewboard.kde.org/r/104117/diff/
> 
> 
> Testing
> -------
> 
> User confirmed that the change fixes the resource not syncing issue, make test \
> still passes. 
> 
> Thanks,
> 
> Andras Mantia
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]