--===============8847281771561731625==
Content-Type: multipart/signed;
  boundary="nextPart2816966.a4ODfit92z";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2816966.a4ODfit92z
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

On Monday, 2012-02-27, Jonathan Marten wrote:
> I've been investigating bug 259963 (wrong context menu when clicking
> over a blank area in the middle column in KAddressBook).  The problem
> seems to be in Akonadi::EntityTreeView::contextMenuEvent() where it
> looks at the clicked index to see whether it is a valid Item, and
> chooses the menu accordingly.  The problem is that, if the click is
> over blank space, there is no way to tell whether the item or
> collection menu should apply.
>=20
> The only fix that I can think of so far is to add a property to the
> EntityTreeView to indicate whether the view is showing items or
> collections, to be set by the calling application.  It would only be
> used in the case of a click not over anything, and the default
> operation if this were not set would be the same as before so other
> applications should not break.

What about derving from EntityTreeView in KAddressBook and overwriting the=
=20
event handler method, delegating to base class implementation when event=20
position is on a valid item?

I am not sure clicking in empty space will always result in either collecti=
on=20
or item context menu, an application could want different behavior.

Cheers,
Kevin

=2D-=20
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

--nextPart2816966.a4ODfit92z
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQBPS6rQnKMhG6pzZJIRAnzqAJ4jSvv0aRu6WOxY/62GoPcDdiPZbwCbBxGA
fJ8oGBi/MNQHxzJOeGfwf7E=
=JjWv
-----END PGP SIGNATURE-----

--nextPart2816966.a4ODfit92z--

--===============8847281771561731625==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============8847281771561731625==--