[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Fixed configuration GUI for the Nepomuk Akonadi feeder
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2012-02-18 11:53:47
Message-ID: 20120218115347.20205.46990 () vidsolbach ! de
[Download RAW message or body]



> On Feb. 14, 2012, 5:17 p.m., Volker Krause wrote:
> > nepomuk/kcm/nepomukserverkcm.cpp, line 258
> > <http://git.reviewboard.kde.org/r/103982/diff/1/?file=49490#file49490line258>
> > 
> > I fixed this part last weekend on the kdepim side, changing it here would break it again.
> 
> Sebastian Trueg wrote:
> How did you fix that? Did you add per-plugin disabling to the feeder?
> 
> Christian Mollekopf wrote:
> He just changed the KConfigGroup identifier to read the settings in the nepomukfeeder.
> 
> Sebastian Trueg wrote:
> I did not find that in the master of 4.8 branched. Also it seems like a very ugly fix in the wrong \
> place. Why would the akonadi_nepomuk_feeder read its settings from akonadi_nepomuk_email_feederrc? Or \
> did I misunderstand? In any case I think this is the place to fix it.
> 
> Christian Mollekopf wrote:
> The commit is 50c9013315b338a5b080ef708a6af4371250e9c8 in master, it might need to be backported. In \
> either case I think it was fixed in a reasonable way. Currently the option is only about email feeding \
> (which makes sense as this is the major part that gets indexed and is probably easier to the user), but \
> actually all indexing is disabled. By using akonadi_nepomuk_email_feederrc we kind of have per plugin \
> (notes/email/calendar/...) settings, which we probably want at some point. So I'd like to keep it that \
> way, unless there is a real problem with that.

The reason I fixed it this way was backwards compatibility with what the older systemsettings module did. \
It has been backported to 4.8 by now.


- Volker


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103982/#review10634
-----------------------------------------------------------


On Feb. 14, 2012, 2:49 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103982/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 2:49 p.m.)
> 
> 
> Review request for KDEPIM, Volker Krause and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> Ever since KDE 4.8 there is no email_feeder agent anymore. All is handled by one feeder now which has \
> different plugins. These plugins cannot be disabled separately yet. Thus, the only way to do it is to \
> disable the whole indexer. This will not actually disable all indexing - but that is another story. 
> 
> Diffs
> -----
> 
> nepomuk/kcm/nepomukserverkcm.cpp 1ccc405 
> 
> Diff: http://git.reviewboard.kde.org/r/103982/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]