[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Fixed item existance check in the Nepomuk feeder
From:       "Kevin Krammer" <kevin.krammer () gmx ! at>
Date:       2012-02-16 10:50:56
Message-ID: 20120216105056.18678.44305 () vidsolbach ! de
[Download RAW message or body]



> On Feb. 15, 2012, 10:29 a.m., Milian Wolff wrote:
> > As an actual review: if LiteralValue does not cope with QUrl, why does this \
> > compile then? I strongly urge you to cleanup the soprano API to prevent such \
> > mistakes then.
> 
> Sebastian Trueg wrote:
> Is making a constructor explicit BC?

My guess would be BC (code that already invokes the constructor for type conversion \
can still do so) but not SC (code that built due to type conversion will no longer \
compile). But probably ask on kde-core-devel to be sure


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103980/#review10661
-----------------------------------------------------------


On Feb. 14, 2012, 2:03 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103980/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2012, 2:03 p.m.)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Description
> -------
> 
> The Nepomuk feeder contains a check to see if a certain item exists. This check \
> uses containsAnyStatement( Soprano::Node(), ANEO::akonadiItemId(), \
> Soprano::LiteralValue( QUrl( QString::number( item.id() ) ) ) ) This will result in \
> an invalid LiteralValue since the latter does not handle URLs. This in turn means \
> that the check will always return true if there is at least one statement with \
> property ANEO::akonadiItemId() in the database. 
> This patch fixes it by using a string rather than a QUrl.
> 
> 
> Diffs
> -----
> 
> agents/nepomukfeeder/feederqueue.cpp 9274daf 
> 
> Diff: http://git.reviewboard.kde.org/r/103980/diff/
> 
> 
> Testing
> -------
> 
> No testing done yet.
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]