[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Refactoring handling IMAP responses during login phase in Akonadi
From:       "Oleg Girko" <ol+kde () infoserver ! ru>
Date:       2012-02-14 22:52:18
Message-ID: 20120214225218.7824.65530 () vidsolbach ! de
[Download RAW message or body]



> On Feb. 14, 2012, 9:42 p.m., Kevin Ottens wrote:
> > I don't get your fixation on not moving ResponseCode to KIMAP::Message but ok... \
> > why not. 
> > Please commit and push. Don't forget to commit it both in master and the 4.8 \
> > branch.

It's not a fixation, I'm just strongly opposing to making this change less isolated. \
:-)

I've pushed changes to master and KDE/4.8 branches on git.kde.org.

Are there any bugfix releases planned for KDE 4.7? If so, I can push the change to \
KDE/4.7 branch as well.


- Oleg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103854/#review10640
-----------------------------------------------------------


On Feb. 13, 2012, 4:40 a.m., Oleg Girko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103854/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 4:40 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Refactoring KIMAP::LoginJob::handleResponse() method in kimap/loginjob.cpp file to \
> make its logic more readable, straightforward and correct. As a side effect, it \
> fixes https://bugs.kde.org/show_bug.cgi?id=249992 by handling untagged CAPABILITY \
> responses more correct and uniform way. 
> This change is trivially backportable to KDE 4.7 (tested with KDE 4.7.4).
> 
> 
> This addresses bug 249992.
> http://bugs.kde.org/show_bug.cgi?id=249992
> 
> 
> Diffs
> -----
> 
> kimap/loginjob.cpp fad276d957e46fd00efa20a5f235d02a639ab2c4 
> 
> Diff: http://git.reviewboard.kde.org/r/103854/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested with Dovecot IMAP server 2.0.17 using CRAM-MD5 and GSSAPI \
> authentication with unencrypted and SSL connection. Also tested with GMail's own \
> IMAP server using SSL connection and LOGIN authentication. 
> 
> Thanks,
> 
> Oleg Girko
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]