From kde-pim  Tue Feb 07 23:24:11 2012
From: "Allen Winter" <winter () kde ! org>
Date: Tue, 07 Feb 2012 23:24:11 +0000
To: kde-pim
Subject: Re: [Kde-pim] Review Request: compact printing style for kaddressboook
Message-Id: <20120207232411.10703.24919 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-pim&m=132865728023685



> On Feb. 5, 2012, 3:03 p.m., Allen Winter wrote:
> > In general looks really good.  You are missing tooltips and whatsthis for the options in the .ui file.  
> > btw, do you have commit account yet?  If not, maybe you should consider getting one.
> 
> Mario Scheel wrote:
>     No, I haven't a commit account

Ok, I will commit this for you.

I would support a commit account for you -- so if you plan to continue developing KDE code ( and I hope you do) then please consider getting an account.  Please visit http://techbase.kde.org/Contribute/Get_a_Contributor_Account for more info.


- Allen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103868/#review10351
-----------------------------------------------------------


On Feb. 7, 2012, 7:52 p.m., Mario Scheel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103868/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 7:52 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Add a new printing style to kaddressbook. Its generate a list of contacts. See also https://bugs.kde.org/show_bug.cgi?id=290438. Its a better solution.
> 
> This patch allows customize the list, the fields are selectable, the colors also.
> 
> 
> Diffs
> -----
> 
>   kaddressbook/CMakeLists.txt a96c8306e767e7689459cd226dbd5ed19b683a76 
>   kaddressbook/printing/compactstyle.h PRE-CREATION 
>   kaddressbook/printing/compactstyle.cpp PRE-CREATION 
>   kaddressbook/printing/compactstyle.ui PRE-CREATION 
>   kaddressbook/printing/pictures/CMakeLists.txt 43f6cb069c533f06fa9623ce02beb36422001e02 
>   kaddressbook/printing/pictures/compact-style.png PRE-CREATION 
>   kaddressbook/printing/printingwizard.cpp f6f7fbe54b9311c18f99ea2c55d603884ee48a98 
> 
> Diff: http://git.reviewboard.kde.org/r/103868/diff/diff
> 
> 
> Testing
> -------
> 
> It compiles and do that I want.
> 
> 
> Thanks,
> 
> Mario Scheel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/