[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: fix email validator to allow typing
From:       "Torgny Nyblom" <kde () nyblom ! org>
Date:       2012-01-06 20:52:07
Message-ID: 20120106205207.16690.96610 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102579/#review9623
-----------------------------------------------------------


Any progress?

- Torgny Nyblom


On Sept. 11, 2011, 3:42 p.m., Julian Bäume wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102579/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2011, 3:42 p.m.)
> 
> 
> Review request for KDEPIM and Marc Mutz.
> 
> 
> Description
> -------
> 
> When typing an email address into a QLineEdit, it is verified on the fly. Domains \
> must not end with a dash, but during typing it might. In this case the validator \
> must know, that this address is not complete, yet. This is already done for the TLD \
> part of the domain, but this doesn't take dashes into account. 
> This patch extends the verification logic to handle dashes during typing.
> 
> FIX: #260371
> 
> 
> This addresses bug 260371.
> http://bugs.kde.org/show_bug.cgi?id=260371
> 
> 
> Diffs
> -----
> 
> kleopatra/utils/validation.cpp d3cd91a 
> 
> Diff: http://git.reviewboard.kde.org/r/102579/diff/diff
> 
> 
> Testing
> -------
> 
> Without this patch applied, one can't enter email addresses with dashes in the \
> domain part. 
> With this patch applied it is possible to do so.
> 
> 
> Thanks,
> 
> Julian Bäume
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]