[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Hide read feeds feature
From:       "Kevin Tardif" <kiyoka () gmail ! com>
Date:       2011-12-12 19:26:13
Message-ID: 20111212192613.30045.32646 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103382/
-----------------------------------------------------------

(Updated Dec. 12, 2011, 7:26 p.m.)


Review request for KDEPIM.


Description (updated)
-------

This patch adds a new option, to hide feeds with zero unread count from the feed \
list. You can access the setting via either the View menubar item or via the General \
configuration panel, it defaults to being turned off. The associated bug report for \
this is https://bugs.kde.org/show_bug.cgi?id=104277 which was prematurely closed due \
to misunderstanding of what the feature was.

List of file modifications:

subscriptionlistmodel:
    - filter models are present in articlelistview, but controller only
      includes listmodel.h, so I put FilterUnreadProxyModel here

    - added FilterUnreadProxyModel, a QSortFilerProxyModel subclass to
      filter out feeds with zero unread count
    - uint nodeIdForIndex(const QModelIndex&) is now a file-specific method
    - changed FolderExpansionHandler::m_model to be of type
      QAbstractItemModel* (since it no longer needs
      SubscriptionListModel::nodeIdForIndex)
    - segfault occurs on exit in SubscriptionListModel::index,
      nodeForIndex returns NULL; added a check for null return here

selectioncontroller:
    - hooked filter's selectionmodel's selectionChanged signal in
      SelectionController::setFeedSelector to the FilterUnreadProxyModel
      instance
    - m_subscriptionModel is now a FilterUnreadProxyModel*
    - added SelectionController::settingsChanged slot
    - changed SelectionController::setFeedList to set the proxy's source
    - model

actionmanagerimpl:
    - added slotSettingsChanged slot for receiving
      MainWidget::signalSettingsChange signal and updating action state
    - added a KAction to ActionManagerImpl:initSubscriptionListView,
      connected to SubscriptionListView::slotToggleHideReadFeeds

subscriptionlistview:
    - added a public slot to connect the added action to (slotToggleHideReadFeeds)

mainwidget:
    - hooked m_part's signalSettingsChanged() to \
m_selectionController::settingsChanged,  m_actionManager::slotSettingsChanged

interfaces/akregator.kcfg:
    - added View/HideReadFeeds entry

akregator_part.rc:
    - add a separator and an action to <Menu name="view"> (name=feed_hide_read)

settings_general.ui:
    - add kcfg_HideReadFeeds field under General->Global


Diffs
-----

  akregator/configuration/settings_general.ui \
c496ebb237110766902d52d5e9eeb8fadcd6130d   akregator/interfaces/akregator.kcfg \
c715100370b5260542fad56ebab11b127228dd7f   akregator/src/actionmanagerimpl.h \
53c11be7ed3db96a158277f020bd55ec02615ca7   akregator/src/actionmanagerimpl.cpp \
2f558c8914e3858fbeefaefba1f6ba4199acc71b   akregator/src/akregator_part.cpp \
6ce7350c83a94b35d62f5510ef6478f942843097   akregator/src/akregator_part.rc \
4756b7d545d288bf103c06c5faeb7a9dee9bdefc   akregator/src/mainwidget.cpp \
8c194e4807de853a4a8c881a711830feaa7a0429   akregator/src/selectioncontroller.h \
21e3f4770adeee0dc155347b1bd60abf6ce511b9   akregator/src/selectioncontroller.cpp \
5fc51cc1ec3ba567fd471cb27d148bdcfceae566   akregator/src/subscriptionlistmodel.h \
ad855ef82b5f07d43c580bb1e0327207bb06dd88   akregator/src/subscriptionlistmodel.cpp \
5491d3204683eef992f8384f8dba9e8489e33b22   akregator/src/subscriptionlistview.h \
2f147d87a33d853927459e27ac413b0477693318   akregator/src/subscriptionlistview.cpp \
de417574c8d5da538983515727284bac563dbe32 

Diff: http://git.reviewboard.kde.org/r/103382/diff/diff


Testing
-------


Thanks,

Kevin Tardif

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]