[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: (minor) correct C&P error in
From:       "Andras Mantia" <amantia () kde ! org>
Date:       2011-12-05 11:51:59
Message-ID: 20111205115159.16799.32026 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103334/#review8722
-----------------------------------------------------------

Ship it!


Looks good for me.

- Andras Mantia


On Dec. 5, 2011, 11:29 a.m., Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103334/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2011, 11:29 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Volker Krause.
> 
> 
> Description
> -------
> 
> It looks like the code for the 2-argument version of collectionChanged() was copied \
> and pasted from itemChanged and uses partIdentifiers for the second param, instead \
> of changedAttributes. AFAIK collections have attributes and properties but not \
> parts, and this error propagated into the nepomuk feeder, so I'm fixing it at \
> source. 
> 
> Diffs
> -----
> 
> akonadi/agentbase.cpp 7e36bd6 
> akonadi/agentbase_p.h 34e3288 
> 
> Diff: http://git.reviewboard.kde.org/r/103334/diff/diff
> 
> 
> Testing
> -------
> 
> make clean && make
> 
> 
> Thanks,
> 
> Will Stephenson
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]