[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Patch for GetQuotaRoot job in kimap
From:       "Kevin Krammer" <kevin.krammer () gmx ! at>
Date:       2011-11-16 9:01:36
Message-ID: 20111116090136.31813.69588 () vidsolbach ! de
[Download RAW message or body]



> On Nov. 16, 2011, 8:14 a.m., Kevin Krammer wrote:
> > kimap/getquotarootjob.cpp, line 85
> > <http://git.reviewboard.kde.org/r/103150/diff/1/?file=41157#file41157line85>
> > 
> > since d->rootIndex is not a local variable, have you checked that other code is \
> > not depending on it being set here?
> 
> Lukáš Krejčí wrote:
> d is the private class instance so its usage is limited to this file. There are no \
> other usages of the rootIndex field other than in the handleResponse method. \
> Because the patch does away with that usage, the field should actually be dropped I \
> think.

If it is not accessed anywhere else I would suggest to indeed remove it.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103150/#review8221
-----------------------------------------------------------


On Nov. 16, 2011, 7:22 a.m., Lukáš Krejčí wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103150/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 7:22 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Andras Mantia.
> 
> 
> Description
> -------
> 
> This is a proposed patch for the get quota root bug.
> 
> 
> This addresses bug 264622.
> http://bugs.kde.org/show_bug.cgi?id=264622
> 
> 
> Diffs
> -----
> 
> kimap/getquotarootjob.cpp f82bf40 
> 
> Diff: http://git.reviewboard.kde.org/r/103150/diff/diff
> 
> 
> Testing
> -------
> 
> Manual - created the imap resource and encountered no crash on startup. KMail2 was \
> able to read mails afterwards. I didn't have time to come up with a unit test nor \
> will I have much time to do it in the future but I think I can provide a dump of \
> communication between kimap and my IMAP server which the unit test could be based \
> on if someone is interested. 
> 
> Thanks,
> 
> Lukáš Krejčí
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]