[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: avoid the use of an undefined
From:       "Kevin Krammer" <kevin.krammer () gmx ! at>
Date:       2011-10-03 16:56:15
Message-ID: 20111003165615.23808.33030 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102765/#review7045
-----------------------------------------------------------


I am not sure what this will achieve. The current code makes the DefaultResourceJob \
result in an error. Wouldn't your change make it claim it succeeded?

- Kevin Krammer


On Oct. 3, 2011, 4:41 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102765/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2011, 4:41 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Within the file
> kdepimlibs/akonadi/specialcollectionshelperjobs.cpp
> at the method:
> DefaultResourceJobPrivate::collectionFetchResult( KJob *job )
> I found a problem: if the job has no collection, info is given with
> collections.count()
> the loop
> foreach ( const Collection &collection, collections ) {
> will not be entered. The variable 
> resourceCollection
> is declared but nothing is assigned to it.
> I think, it is not allowed to use it, such as a few lines below
> if ( !resourceCollection.isValid() ) {
> 
> My proposal: 
> Test the count, and just return if zero.
> 
> 
> Diffs
> -----
> 
> akonadi/specialcollectionshelperjobs.cpp ebc79c3 
> 
> Diff: http://git.reviewboard.kde.org/r/102765/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]