[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: Check that
From:       "Kevin Krammer" <kevin.krammer () gmx ! at>
Date:       2011-09-28 22:00:00
Message-ID: 20110928220000.1077.49270 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102616/#review6896
-----------------------------------------------------------


Looks ok to me, but better add Stephen Kelly to the list of reviewers, he's the ETM \
man

- Kevin Krammer


On Sept. 15, 2011, 11:39 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102616/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2011, 11:39 a.m.)
> 
> 
> Review request for Akonadi and KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> I was experiencing crashes when updating iCal resources, similar to bug 273676 (but \
> probably not the same) and after some debugging I found out that the Q_ASSERT to \
> check that m_collection indeed has the key to remove (line 1030) was causing the \
> issue. Adding a check to be sure the key is indeed in m_collections should fix \
> that, but I'm not sure if code should worry more about why the key is not in \
> m_collections or just do the check. Makes sense? 
> 
> This addresses bug 273676.
> http://bugs.kde.org/show_bug.cgi?id=273676
> 
> 
> Diffs
> -----
> 
> akonadi/entitytreemodel_p.cpp d3ab393 
> 
> Diff: http://git.reviewboard.kde.org/r/102616/diff/diff
> 
> 
> Testing
> -------
> 
> 1. Add an iCal resource (I'm actually not sure if this happens with all iCal \
> resources, if needed I could point at one URL which fails in all of my KDE 4.7 \
> installations) 2. Plasma crashes
> 3. Apply the patch and restart plasma-desktop
> 4. Open KOrganizer and update the iCal resource, plasma should not crash now
> 
> 
> Thanks,
> 
> David Narváez
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]