[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: akregator: bug fix 245911: crash when
From:       "Kevin Krammer" <kevin.krammer () gmx ! at>
Date:       2011-08-30 6:11:47
Message-ID: 20110830061147.26912.41750 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102333/#review6161
-----------------------------------------------------------

Ship it!


There have been no objections and the error case around line 144 seems to be handled \
like this already.

I guess it would be nice if this could be backported/cherry-picked into 4.7 branch as \
well. Thanks!

- Kevin


On Aug. 15, 2011, 7:49 p.m., Marta Rybczyńska wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102333/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 7:49 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Akregator segfaults when the feed list is damaged, and we try to add a new feed. \
> The reason for this is that the FeedList object to be used is never correctly \
> created, do it stays at 0. This patch provides possibly the easiest solution to the \
> problem: when the feed is damaged, we use the default feed. 
> 
> This addresses bug 245911.
> http://bugs.kde.org/show_bug.cgi?id=245911
> 
> 
> Diffs
> -----
> 
> akregator/src/loadfeedlistcommand.cpp dda20a4 
> 
> Diff: http://git.reviewboard.kde.org/r/102333/diff
> 
> 
> Testing
> -------
> 
> Tested in the situation that previously caused the bug, works fine. Should not \
> affect other cases. 
> 
> Thanks,
> 
> Marta
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]