[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] kmail network-awareness patch
From: laurent Montel <montel () kde ! org>
Date: 2011-08-20 10:53:19
Message-ID: 1439708.6KVZLiUWjJ () krita
[Download RAW message or body]
Le Saturday 20 August 2011 11:59:08 Martin Bednár a écrit :
> Hi,
>
> I played around with some kmail code to make it a bit more networkstatus-
aware
> (via solid) than it was. I'm not sure it's really needed functionality-wise,
> but my ultimate goal being a connected/disconnected icon in the status bar,
I
> think these changes are useful.
>
> Also, what's your view on merging setAccountOnline() and setAccountOffline()
> from kmkernel.cpp into one function setAccountStatus(bool) ?
>
> Cheers,
>
> Martin
Hi,
for me patch is good.
And yes please merge setAccountOnline/Offline
Just a little pb:
"+void KMMainWidget::slotNetworkStatusChanged ( Solid::Networking::Status
status)
+{
+ if ( status == Solid::Networking::Connected && GlobalSettings::self()-
>networkState() == GlobalSettings::EnumNetworkState::Online ) {
+ BroadcastStatus::instance()->setStatusMsg(i18n("Network connection
detected, all network jobs resumed"));
+ kmkernel->setAccountOnline();
+ }
+ else {
+ BroadcastStatus::instance()->setStatusMsg(i18n("No network connection
detected, all network jobs are suspended"));
+ kmkernel->setAccountOffline();
+ }
+}
" if ( status == Solid::Networking::Connected && GlobalSettings::self()-
networkState() == GlobalSettings::EnumNetworkState::Online ) {"
When status is connected and "GlobalSettings::EnumNetworkState::Offline" you
display "No network connection detected, all network jobs are suspended" it's
not right. for me because you are connection but just kmail is offline.
=> perhaps:
Not necessary to display change network status when we are offline.
void KMMainWidget::slotNetworkStatusChanged ( Solid::Networking::Status
status)
{
if( GlobalSettings::self()->networkState() ==
GlobalSettings::EnumNetworkState::Offline )
return;
if ( status == Solid::Networking::Connected ) {
BroadcastStatus::instance()->setStatusMsg(i18n("Network connection
detected, all network jobs resumed"));
kmkernel->setAccountOnline();
}
else {
BroadcastStatus::instance()->setStatusMsg(i18n("No network connection
detected, all network jobs are suspended"));
kmkernel->setAccountOffline();
}
}
Otherwise it's ok to commit in master (not in 4.7 because it adds new i18n)
Thanks
Regards
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic