[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request: ktimetracker - fix a bit desktop
From:       "Torgny Nyblom" <kde () nyblom ! org>
Date:       2011-08-15 18:08:49
Message-ID: 20110815180849.27685.66930 () vidsolbach ! de
[Download RAW message or body]



> On May 20, 2011, 7 p.m., Torgny Nyblom wrote:
> > And there is the reason why statements without braces is a bad idea.

Any progress?


- Torgny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100951/#review3429
-----------------------------------------------------------


On March 26, 2011, 12:22 p.m., Cristi Posoiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100951/
> -----------------------------------------------------------
> 
> (Updated March 26, 2011, 12:22 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> While debugging something else, ktimetracker was loading the data file, resumed one \
> running task, and then immediately stopped the task. It seems there is some code \
> that wasn't running under the appropriate 'if' condition. This patch should fix it \
> - you can look a couple of lines below to see the same emit call done *only* when \
> the task was really in the desktop. I think that in normal use, this might not be \
> reproducible - I am getting the registerForDesktops called w/ an empty list - most \
> probably because I was running kde trunk in a Xephyr window (i.e. no multiple \
> desktops?). 
> 
> Diffs
> -----
> 
> ktimetracker/desktoptracker.cpp c3e0f83 
> 
> Diff: http://git.reviewboard.kde.org/r/100951/diff
> 
> 
> Testing
> -------
> 
> - add a task
> - start it
> - close timetracker (prefferably via File->Close; File->Quit - see other patch just \
>                 added for the reason)
> - start timetracker
> - expected result: task is resumed and running;
> - without patch: task is stopped.
> 
> Mandatory: not having virtual desktops or something - i.e. I had this running in a \
> Xephyr window. 
> 
> Thanks,
> 
> Cristi
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]