[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: kmail: now it is allowed to create a
From:       "Torgny Nyblom" <kde () nyblom ! org>
Date:       2011-07-21 18:50:35
Message-ID: 20110721185035.13018.84431 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102031/#review4942
-----------------------------------------------------------


Can't really say go/no go but it feels wrong to initialize the rights to \
"CanCreate..." and not "ReadOnly".


resources/imap/addcollectiontask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4313>

    Is this really portable?
    
    Ie. does all imap servers use this char as a separator?



resources/imap/retrievecollectionstask.cpp
<http://git.reviewboard.kde.org/r/102031/#comment4314>

    What is the reason for this?


- Torgny


On July 21, 2011, 4:46 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102031/
> -----------------------------------------------------------
> 
> (Updated July 21, 2011, 4:46 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> On kmail 2, if you try to add a folder under your top imap folder, you will see \
> that the button "Add folder" is disable. This patch is fixing this issue. 
> 
> This addresses bug 251704.
> http://bugs.kde.org/show_bug.cgi?id=251704
> 
> 
> Diffs
> -----
> 
> resources/imap/addcollectiontask.cpp 5ce6aec 
> resources/imap/retrievecollectionmetadatatask.cpp 3c9ead4 
> resources/imap/retrievecollectionstask.cpp 48f0e57 
> 
> Diff: http://git.reviewboard.kde.org/r/102031/diff
> 
> 
> Testing
> -------
> 
> Kdepim and kdepim-runtime compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]