[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Old Akonadi Server Config
From:       Volker Krause <vkrause () kde ! org>
Date:       2011-06-20 8:12:32
Message-ID: 1381011.i3YJme82iH () vkpc9
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 19 June 2011 18:52:22 Kevin Krammer wrote:
> On Saturday, 2011-06-18, Kevin Krammer wrote:
> > Hi all,
> > 
> > since our 4.6.0 release I keep an eye on various user channels to see
> > which problems come up and how the early adopters cope with them.
> > 
> > One rather nasty issue is ExternalPayload=false in akonadiserverrc which
> > I think will bite almost everyone who did not start with a new user
> > account on a recent release.
> > 
> > Effects of this setting are people not being able to copy emails between
> > recources (a user reports copying only copied headers), DIMAP accounts
> > only caching headers, etc.
> 
> Just as an example:
> https://bugs.kde.org/show_bug.cgi?id=275561#c9
> 
> > Do we actually need this setting, i.e. can't we just ignore it if
> > present?
> 
> I had a quick look at the respective server code and I came up with three
> options:
> 
> 1) in DbConfig constructor, remove the line that reads the config entry.
> Would still allow subclasses to override by reimplementing
> useExternalPayload()
> 
> 2) Adapt the code calling the method to use the configured threshold when
> true and use the database's maximum blob size when false, i.e. always store
> file if necessary.
> 
> 3) Remove all usages of the method.
> 
> Any thoughts?

This option was mainly introduced to test this feature during development, 
without enabling it for everyone, so we can drop it now IMHO. So, I'd either 
go with (1) (easier to implement) or (3) (probably cleaner).

Thanks for looking into this issue.

regards
Volker

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]