[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: Kmail: Custom drafts and templates
From:       "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date:       2011-05-22 23:29:01
Message-ID: 20110522232901.17815.65503 () vidsolbach ! de
[Download RAW message or body]



> On May 20, 2011, 4:02 p.m., Kevin Krammer wrote:
> > messagecomposer/composerviewbase.cpp, line 928
> > <http://git.reviewboard.kde.org/r/101391/diff/2/?file=16775#file16775line928>
> > 
> > I know this is not part of your change, but overwriting target (which has been \
> > initialized with suitable default) without checking looks bad to me. Should \
> > probably be done in an extra review

In case of a custom collection, my patch is checking to find out if the collection \
exist. Why should we add another check?


> On May 20, 2011, 4:02 p.m., Kevin Krammer wrote:
> > messagecomposer/composerviewbase.cpp, line 915
> > <http://git.reviewboard.kde.org/r/101391/diff/2/?file=16775#file16775line915>
> > 
> > Since saving becomes asynchronous, it might be better to add the message to the \
> > job as a custom property. Maybe already as an item

We don't have a private Akonadi::Item like we have the m_msg. So how could this be \
possible? But we can put it together with the Akonadi::CollectionFetchJob.


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101391/#review3424
-----------------------------------------------------------


On May 20, 2011, 2:55 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101391/
> -----------------------------------------------------------
> 
> (Updated May 20, 2011, 2:55 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If someone is trying to save a draft or a template mail and the custom collection \
> doesn't exist then the mail is lost. With this patch, if the custom collection \
> doesn't exist then the mail is saved in the default draft and template folders. \
> (Which are created by the Akonadi::SpecialMailCollections) 
> 
> Diffs
> -----
> 
> messagecomposer/composerviewbase.h 3b0a315 
> messagecomposer/composerviewbase.cpp 9a7d5c3 
> 
> Diff: http://git.reviewboard.kde.org/r/101391/diff
> 
> 
> Testing
> -------
> 
> kdepim compiles and runs without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]