[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim]  Review Request: make autoSaveCopyResult conform
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2011-04-09 18:00:58
Message-ID: 20110409180058.31425.3814 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101072/
-----------------------------------------------------------

Review request for KDEPIM.


Summary
-------

Regarding to kdelibs/kdecore/jobs/kjobs.h at line 52:
   if ( job->error() )
       doSomething();
because of, at line 254:
   @return the error code for this job, 0 if no error.
is the method autoSaveCopyResult not conform. It produces an error:
kmail-migrator(1691) KMail::KMailMigrator::autoSaveCopyResult: error= 0 text= "Unknown error code 0

I propose to add one line.


Diffs
-----

  migration/kmail/kmailmigrator.cpp 7adeef8 

Diff: http://git.reviewboard.kde.org/r/101072/diff


Testing
-------


Thanks,

Guy

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]