[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: Avoid overlapping memcpy in kio_imap
From:       "Allen Winter" <winter () kde ! org>
Date:       2011-01-21 16:58:03
Message-ID: 20110121165803.4931.4538 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6389/#review9670
-----------------------------------------------------------


ok, i'm committing it to trunk (for 4.7) and 4.6,4.5,4.4

please close this review as committed.

- Allen


On Jan. 20, 2011, 6:08 p.m., Thomas Jarosch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6389/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2011, 6:08 p.m.)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Avoid overlapping memcpy in kio_imap.
> (Fixes serious crashes on Fedora 14)
> 
> Related article: http://lwn.net/Articles/414467/
> 
> ==4767== Source and destination overlap in memcpy(0x4d25b18, 0x4d25b1a, 33)
> ==4767==    at 0x4A073BA: memcpy (mc_replace_strmem.c:602)
> ==4767==    by 0xB10A9AF: IMAP4Protocol::myRead(void*, long) (string3.h:52)
> ==4767==    by 0xB10AAE4: IMAP4Protocol::parseRead(QByteArray&, long, long) \
> (imap4.cpp:680) ==4767==    by 0xB125535: imapParser::parseLiteral(parseString&, \
> bool, bool) (imapparser.cpp:1897) ==4767==    by 0xB12D798: \
> imapParser::parseBody(parseString&) (imapparser.cpp:1382) ==4767==    by 0xB12E1D1: \
> imapParser::parseFetch(unsigned long, parseString&) (imapparser.cpp:1490) ==4767==  \
> by 0xB12EF84: imapParser::parseUntagged(parseString&) (imapparser.cpp:495) ==4767== \
> by 0xB12F4FD: imapParser::parseLoop() (imapparser.cpp:1743) ==4767==    by \
> 0xB11DFD7: IMAP4Protocol::get(KUrl const&) (imap4.cpp:338) ==4767==    by \
> 0x3D60D928A4: KIO::SlaveBase::dispatch(int, QByteArray const&) (in \
> /usr/lib64/libkio.so.5.5.0) ==4767==    by 0xB108843: IMAP4Protocol::dispatch(int, \
> QByteArray const&) (imap4.cpp:1828) ==4767==    by 0x3D60D8CBC2: \
> KIO::SlaveBase::dispatchLoop() (in /usr/lib64/libkio.so.5.5.0) 
> 
> Diffs
> -----
> 
> /trunk/KDE/kdepimlibs/kioslave/imap4/imap4.cpp 1198806 
> 
> Diff: http://svn.reviewboard.kde.org/r/6389/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]