[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: Prevent the editing of an attachment
From:       "Thomas McGuire" <mcguire () kde ! org>
Date:       2011-01-02 22:32:59
Message-ID: 20110102223259.10293.2207 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100288/#review703
-----------------------------------------------------------


Thanks for the patch. Looks like it will work, but from a UI point of view, disabling \
the "edit" action would be even better, to avoid confusion. Can you change the patch \
to do that?

- Thomas


On 2011-01-02 20:26:01, George Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100288/
> -----------------------------------------------------------
> 
> (Updated 2011-01-02 20:26:01)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> When the user attempts to forward a message that contains an encapsulated message, \
> they are shown the attachment and can edit it, by double clicking on it. However, \
> in this case, it doesn't make sense to edit the attachment. If the user is allowed \
> to edit the attachment, they get an error in a message box. This patch detects if \
> the user has double clicked on an encapsulated message and proceeds to open the \
> attachment for viewing only. 
> 
> This addresses bug 232782.
> http://bugs.kde.org/show_bug.cgi?id=232782
> 
> 
> Diffs
> -----
> 
> messagecomposer/attachmentcontrollerbase.cpp 1361426 
> 
> Diff: http://git.reviewboard.kde.org/r/100288/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]