[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Re: Review Request: Convert the remainder of KMail
From:       "George Metaxas" <gmetal31 () gmail ! com>
Date:       2011-01-02 17:32:41
Message-ID: 20110102173241.2168.60001 () vidsolbach ! de
[Download RAW message or body]



> On 2011-01-01 21:34:47, Thomas McGuire wrote:
> > Looks good, please commit after making the suggest change I commented about.
> > One thing I noticed is that the composer doesn't use the custom quote colors, I \
> > don't know if that is a side-effect of your patch or not though.

I threw away the mBeepOnNew variable and the mConfirmEmpty, which were trivial (as \
per your suggestion). I think that a more thorough look into it is required. I also \
fixed that problem with the colours. 


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100266/#review694
-----------------------------------------------------------


On 2010-12-31 14:25:21, George Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100266/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 14:25:21)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> The current version of KMail has some parts of its configuration not being accessed \
> through the KConfigXT mechanism, as that is implemented through the various \
> GlobalSettings classes. This patch ports the largest remaining part of the code, to \
> use the GlobalSettings class (and related classes in other namespaces). Some parts \
> of the code have not been ported, such as the handling of configuration with \
> multiple  items of the same type (Akonadi resources, Folders, antispam tool \
> configuration), and some parts of the code that do not really belong to the KMail \
> configuration (the migration process (kmmail-migratorrc), pid and lock stuff). This \
> patch mainly looks at the code in the kmail folder. Some of the configuration \
> entries were moved to a .kcfg file in a different subfolder (such as messagecore or \
> messageviewer). 
> 
> This addresses bug 89446.
> http://bugs.kde.org/show_bug.cgi?id=89446
> 
> 
> Diffs
> -----
> 
> kmail/kmcommands.cpp 2dfbec5 
> kmail/kmcomposereditor.cpp bdee9fb 
> kmail/kmcomposewin.cpp 17af19a 
> kmail/globalsettings_base.kcfgc f9a0ea4 
> kmail/identitydialog.cpp 0535966 
> kmail/kmail.kcfg.cmake fadb2c1 
> kmail/configuredialog.cpp d02cbad 
> kmail/kmfilterdlg.cpp 92d13e4 
> kmail/kmkernel.cpp 61e87a6 
> kmail/kmmainwidget.cpp b26e9ca 
> kmail/kmstartup.cpp ef54d75 
> kmail/searchwindow.cpp 4b5ccdc 
> messagecomposer/messagecomposer.kcfg.cmake 203668a3 
> messagecore/messagecore.kcfg f1a5425 
> messageviewer/messageviewer.kcfg.cmake 3ae0f43 
> 
> Diff: http://git.reviewboard.kde.org/r/100266/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]