From kde-pim Sun Dec 12 18:23:45 2010 From: "Torgny Nyblom" Date: Sun, 12 Dec 2010 18:23:45 +0000 To: kde-pim Subject: [Kde-pim] Re: Review Request: Support recursive collection Message-Id: <20101212182345.19119.44266 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-pim&m=129217828003765 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6083/#review9210 ----------------------------------------------------------- Ship it! Guess my previous comment got sent to /dev/null but you nailed it anyway ;) - Torgny On 2010-12-12 13:16:42, Andras Mantia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6083/ > ----------------------------------------------------------- > > (Updated 2010-12-12 13:16:42) > > > Review request for KDE PIM. > > > Summary > ------- > > As a user I'd expect that syncing a kmail folder syncronizes the folder and its subfolders. Might be useful in other cases as well. This patch implements this in resourcebase and agentmanager and adds a new action to the standard actions. F5 is reassigned to this new action. The user visible name right now is the same because: > 1) i18n freeze > 2) I believe this should be the standard behavior of a sync, so either they should be merged (the old action does recursive sync) or that one renamed when it is allowed. > > > Diffs > ----- > > trunk/KDE/kdepimlibs/CMakeLists.txt 1205753 > trunk/KDE/kdepimlibs/akonadi/agentmanager.h 1205753 > trunk/KDE/kdepimlibs/akonadi/agentmanager.cpp 1205753 > trunk/KDE/kdepimlibs/akonadi/kmime/standardmailactionmanager.cpp 1205753 > trunk/KDE/kdepimlibs/akonadi/resourcebase.h 1205753 > trunk/KDE/kdepimlibs/akonadi/resourcebase.cpp 1205753 > trunk/KDE/kdepimlibs/akonadi/standardactionmanager.h 1205753 > trunk/KDE/kdepimlibs/akonadi/standardactionmanager.cpp 1205753 > > Diff: http://svn.reviewboard.kde.org/r/6083/diff > > > Testing > ------- > > > Thanks, > > Andras > > _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/